Skip to content

Latest commit

 

History

History
52 lines (43 loc) · 4.71 KB

Magic Number Test.rst

File metadata and controls

52 lines (43 loc) · 4.71 KB
Raw

Magic Number Test

Definition:

  • This smell occurs when a test method contains unexplained and undocumented numeric literals as parameters or as values to identifiers. These magic values do not sufficiently indicate the meaning/purpose of the number. Hence, they hinder code understandability. Consequently, they should be replaced with constants or variables, thereby providing a descriptive name for the value.

Code Example:

@Test
public void testGetLocalTimeAsCalendar() {
    Calendar localTime = calc.getLocalTimeAsCalendar(BigDecimal.valueOf(15.5D), Calendar.getInstance());
    assertEquals(15, localTime.get(Calendar.HOUR_OF_DAY));
    assertEquals(30, localTime.get(Calendar.MINUTE));
}

References:

Quality attributes